feat: implement model-specific suffix resolution for M3 mtp as "EAGLE"#469
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Display-label only; omitting
modelongetHardwareConfigkeeps prior MTP behavior, with tests covering cache isolation.Overview
MiniMax-M3 runs stored with
spec_method/ hwKey tokenmtpnow show EAGLE (e.g. suffix(vLLM, M3 EAGLE)) instead of generic MTP. Other models are unchanged.Adds
resolveFrameworkPartLabelandMODEL_SPEC_METHOD_LABELSin@semianalysisai/inferencex-constants, and extendsgetHardwareConfig(hwKey, model?)so suffix parts respect per-model overrides. Model-scoped cache keys avoid leaking M3 labels into model-less lookups.Call sites pass the display model (or row model) into
getHardwareConfigacross inference charts, tables, CSV export, eval labels, submissions, changelog config keys, calculator throughput, and AI chart bars. SubmissionsTable and eval/changelog builders use the same resolver for spec-method cells and headers.Reviewed by Cursor Bugbot for commit 1c96c70. Bugbot is set up for automated code reviews on this repo. Configure here.